Fix incorrect alpha value update of InteractiveFrame #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow, great catch! It seems the original implementation was a bit more sensible. I guess the change was an attempt to thwart undefined behavior, but I think that motivation was a bit misguided considering the result. |
mxgrey
approved these changes
Apr 29, 2019
|
Yeah, motivation was good but the change was accompanied with a silent error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #1217,
InteractiveFramedoesn't display correctly. This is because the element access operator ofaiColor4Dwith index 3 doesn't point to the alpha component but interestingly red component.This PR workaround by using the member variable instead. It'd be ideal to be fixed in the upstream though.
Fixes #1217.
Before creating a pull request
clang-formatBefore merging a pull request
CHANGELOG.md